fix: use List interface instead of ArrayList in TransformationService

[sonarqube-agent]

Changed the return type of the unwind method from ArrayList to List to adhere to best practices of returning interface types rather than concrete implementations. This improves code flexibility and maintainability by allowing implementations to be swapped without affecting the method signature.

View Project in SonarCloud

---

Fixed Issues

java:S1319 - The return type of this method should be an interface such as "List" rather than the implementation "ArrayList". • MINOR • View issue

Location: src/main/java/fr/ans/psc/pscextract/service/TransformationService.java:149

Why is this an issue?

The Java Collections API offers a well-structured hierarchy of interfaces designed to hide collection implementation details. For the various collection data structures like lists, sets, and maps, specific interfaces (java.util.List, java.util.Set, java.util.Map) cover the essential features.

What changed

Changes the return type of the public method unwind from the concrete implementation ArrayList<Ps> to the interface type List<Ps>. This directly fixes the code smell where a collection implementation class (ArrayList) was used as a public method return type instead of the appropriate interface (List).

--- a/src/main/java/fr/ans/psc/pscextract/service/TransformationService.java
+++ b/src/main/java/fr/ans/psc/pscextract/service/TransformationService.java
@@ -149,1 +149,1 @@ public class TransformationService {
-    public ArrayList<Ps> unwind(List<Ps> psList) {
+    public List<Ps> unwind(List<Ps> psList) {

Have a suggestion or found an issue? Share your feedback here.

---

SonarQube Remediation Agent uses AI. Check for mistakes.

[sonarqube-agent]

⚠️ This repository does not have a CODEOWNERS file. The PR has been created but has not been automatically assigned to any reviewer. To ensure PRs are reviewed promptly, consider adding a CODEOWNERS file to your repository.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud