fix: resolve 3 SonarQube issues in naming and collection checks

[sonarqube-agent]

Renamed method calls to follow camelCase naming conventions (getZipExtension and getTxtExtension) and replaced size() check with isEmpty() for better clarity and performance. These changes improve code quality by adhering to Java naming standards and using collection API best practices.

View Project in SonarCloud

---

Fixed Issues

java:S100 - Rename this method name to match the regular expression '^[a-z][a-zA-Z0-9]*$'. • MINOR • View issue

Location: src/main/java/fr/ans/psc/pscextract/controller/ExtractionController.java:233

Why is this an issue?

Shared naming conventions allow teams to collaborate efficiently.

What changed

This hunk renames the call from getZIP_EXTENSION() to getZipExtension(), which is part of fixing the method naming convention violation where getZIP_EXTENSION() does not match the required pattern ^[a-z][a-zA-Z0-9]*$. By updating all call sites to use the new compliant name getZipExtension(), the old non-compliant method can be renamed or removed.

--- a/src/main/java/fr/ans/psc/pscextract/service/TransformationService.java
+++ b/src/main/java/fr/ans/psc/pscextract/service/TransformationService.java
@@ -385,1 +385,1 @@ public class TransformationService {
-                         getFileNameWithExtension(extractionController.getZIP_EXTENSION())
+                         getFileNameWithExtension(extractionController.getZipExtension())

java:S100 - Rename this method name to match the regular expression '^[a-z][a-zA-Z0-9]*$'. • MINOR • View issue

Location: src/main/java/fr/ans/psc/pscextract/controller/ExtractionController.java:237

Why is this an issue?

Shared naming conventions allow teams to collaborate efficiently.

What changed

This hunk updates the call from getTXT_EXTENSION() to getTxtExtension(), fixing the method naming convention violation where getTXT_EXTENSION() does not match the required pattern ^[a-z][a-zA-Z0-9]*$. By renaming the call site to use the compliant camelCase name getTxtExtension(), the old non-compliant method can be renamed accordingly.

--- a/src/main/java/fr/ans/psc/pscextract/service/TransformationService.java
+++ b/src/main/java/fr/ans/psc/pscextract/service/TransformationService.java
@@ -437,1 +438,1 @@ public class TransformationService {
-    ZipEntry zipEntry = new ZipEntry(getFileNameWithExtension(extractionController.getTXT_EXTENSION()));
+    ZipEntry zipEntry = new ZipEntry(getFileNameWithExtension(extractionController.getTxtExtension()));

java:S1155 - Use isEmpty() to check whether the collection is empty or not. • MINOR • View issue

Location: src/main/java/fr/ans/psc/pscextract/service/utils/FileNamesUtil.java:66

Why is this an issue?

When you call isEmpty(), it clearly communicates the code’s intention, which is to check if the collection is empty. Using size() == 0 for this purpose is less direct and makes the code slightly more complex.

What changed

Replaces listOfFiles.size() > 0 with !listOfFiles.isEmpty(), which is the recommended way to check whether a collection is empty. Using isEmpty() is clearer in intent, and is guaranteed to be an O(1) operation, whereas size() may be O(n) depending on the collection implementation.

--- a/src/main/java/fr/ans/psc/pscextract/service/utils/FileNamesUtil.java
+++ b/src/main/java/fr/ans/psc/pscextract/service/utils/FileNamesUtil.java
@@ -66,1 +66,1 @@ public class FileNamesUtil {
-    if (listOfFiles.size() > 0) {
+    if (!listOfFiles.isEmpty()) {

Have a suggestion or found an issue? Share your feedback here.

---

SonarQube Remediation Agent uses AI. Check for mistakes.

[sonarqube-agent]

⚠️ This repository does not have a CODEOWNERS file. The PR has been created but has not been automatically assigned to any reviewer. To ensure PRs are reviewed promptly, consider adding a CODEOWNERS file to your repository.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud