Skip to content

fix: resolve code quality issues and improve maintainability #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sonarqube-agent wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: resolve code quality issues and improve maintainability #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pscload/src/test/java/fr/ans/psc/pscload/state/DiffComputedStateTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
*/
@Slf4j
@SpringBootTest
public class DiffComputedStateTest {
class DiffComputedStateTest {

/**
* The custom metrics.
Expand Down
6 changes: 3 additions & 3 deletions pscload/src/test/java/fr/ans/psc/pscload/state/ReadyToComputeDiffTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ void diffTaskTest() throws Exception {
*/
@Test
@DisplayName("initial diff from large file (100000 lines)")
public void diffFromLargeFile() throws Exception {
void diffFromLargeFile() throws Exception {
// ClassLoader cl = Thread.currentThread().getContextClassLoader();
// String rootpath = cl.getResource("work").getPath();
// File mapser = new File(rootpath + File.separator + "maps.ser");
Expand All @@ -225,7 +225,7 @@ public void diffFromLargeFile() throws Exception {
@Test
@Disabled
@DisplayName("check order impact on hashCode and equals methods")
public void checkDifferentOrderForPs() throws IOException {
void checkDifferentOrderForPs() throws IOException {
LoadProcess p = new LoadProcess(new ReadyToComputeDiff(List.of("60"),customMetrics, httpMockServer.baseUrl()));
File file1 = FileUtils.copyFileToWorkspace("2WorkSituationsOrder1");
ReadyToComputeDiff state = (ReadyToComputeDiff) p.getState();
Expand All @@ -246,7 +246,7 @@ public void checkDifferentOrderForPs() throws IOException {
@Test
@Disabled
@DisplayName("check that the order of first names is handled correctly")
public void checkCorrectFirstNameOrder() throws IOException {
void checkCorrectFirstNameOrder() throws IOException {
LoadProcess p = new LoadProcess(new ReadyToComputeDiff(List.of("60"),customMetrics, httpMockServer.baseUrl()));
File file1 = FileUtils.copyFileToWorkspace("FirstNameOrder");
ReadyToComputeDiff state = (ReadyToComputeDiff) p.getState();
Expand Down
2 changes: 1 addition & 1 deletion pscload/src/test/java/fr/ans/psc/pscload/state/SubmittedStateRunTaskTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
@SpringBootTest
@ActiveProfiles("test")
@ContextConfiguration(classes = PscloadApplication.class)
public class SubmittedStateRunTaskTest {
class SubmittedStateRunTaskTest {

/** The http rass mock server. */
@RegisterExtension
Expand Down