Skip to content

Conversation

@itcultus
Copy link

Closes #231

SUMMARY
  • Use correct custom certificate API endpoints (upload/delete)
  • Fix overly generic error messages during certificate upload
  • Exclude default Proxmox certificates (pve-ssl.pem, pve-root-ca.pem) from comparisons
  • Fix state=absent implementation that previously used wrong endpoint
  • Make all return messages more descriptive and user-friendly
  • Add proper force handling and idempotency with leaf fingerprint check

Fixes #231

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

proxmox_node

ADDITIONAL INFORMATION

- Use correct custom certificate API endpoints (upload/delete)
- Fix overly generic error messages during certificate upload
- Exclude default Proxmox certificates (pve-ssl.pem, pve-root-ca.pem) from comparisons
- Fix state=absent implementation that previously used wrong endpoint
- Make all return messages more descriptive and user-friendly
- Add proper force handling and idempotency with leaf fingerprint check

Closes ansible-collections#231
@Thulium-Drake
Copy link
Collaborator

I have approved the CI, can you take a look at the results of the tests? It seems unhappy :-)

@itcultus
Copy link
Author

itcultus commented Dec 3, 2025

I have approved the CI, can you take a look at the results of the tests? It seems unhappy :-)

I saw it and I am puzzled as well. But yeah, let's see.
@Thulium-Drake , the main issue is that I assumed that python 3.7 is not needed anymore.
So, I use walrus assignment in one line. If we still need python 3.7 I can change it.

CHG: Fix indentation in some lines to pass nox
CHG: Remove walrus operator to make it compatible with Python 3.7
@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

❌ Patch coverage is 0% with 36 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.54%. Comparing base (059dda2) to head (129b637).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
plugins/modules/proxmox_node.py 0.00% 36 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #232      +/-   ##
==========================================
- Coverage   69.65%   69.54%   -0.12%     
==========================================
  Files          77       77              
  Lines        8879     8895      +16     
  Branches     1811     1817       +6     
==========================================
+ Hits         6185     6186       +1     
- Misses       2406     2421      +15     
  Partials      288      288              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Thulium-Drake
Copy link
Collaborator

Thanks for this!

Ansible 2.17 is still a valid target for this collection, which supports Python 3.7 on the targets :-) so that's why we still support it.

@Thulium-Drake
Copy link
Collaborator

@IamLunchbox / @JanaHoch Can you also have a look? If you're happy, I'm happy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Very problematic certificate management from proxmox_node module

2 participants