-
Notifications
You must be signed in to change notification settings - Fork 54
proxmox_node: improve certificate management (closes 231) #232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
proxmox_node: improve certificate management (closes 231) #232
Conversation
- Use correct custom certificate API endpoints (upload/delete) - Fix overly generic error messages during certificate upload - Exclude default Proxmox certificates (pve-ssl.pem, pve-root-ca.pem) from comparisons - Fix state=absent implementation that previously used wrong endpoint - Make all return messages more descriptive and user-friendly - Add proper force handling and idempotency with leaf fingerprint check Closes ansible-collections#231
|
I have approved the CI, can you take a look at the results of the tests? It seems unhappy :-) |
I saw it and I am puzzled as well. But yeah, let's see. |
CHG: Fix indentation in some lines to pass nox
CHG: Remove walrus operator to make it compatible with Python 3.7
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #232 +/- ##
==========================================
- Coverage 69.65% 69.54% -0.12%
==========================================
Files 77 77
Lines 8879 8895 +16
Branches 1811 1817 +6
==========================================
+ Hits 6185 6186 +1
- Misses 2406 2421 +15
Partials 288 288 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks for this! Ansible 2.17 is still a valid target for this collection, which supports Python 3.7 on the targets :-) so that's why we still support it. |
|
@IamLunchbox / @JanaHoch Can you also have a look? If you're happy, I'm happy! |
Closes #231
SUMMARY
Fixes #231
ISSUE TYPE
COMPONENT NAME
proxmox_node
ADDITIONAL INFORMATION