Unquote boolean values in the templated HCL files. #341
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `tls_disable` value in particular was causing the UI to show that TLS was disabled despite being actually enabled. That's likely a bug in the Vault UI code, but there's also no reason to quote the boolean values in the rendered HCL file.
lakrass
requested changes
Nov 27, 2025
Contributor
lakrass
left a comment
lakrass
left a comment
There was a problem hiding this comment.
I see your point here!
Please use conventional commits and rebase your branch.
Then I'll approve the PR!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
tls_disablevalue in particular was causing the UI to show that TLS was disabled despite being actually enabled. That's likely a bug in the Vault UI code, but there's also no reason to quote the boolean values in the rendered HCL file.