Skip to content

Conversation

de1987
Copy link

@de1987 de1987 commented Oct 15, 2025

Jira Issue: AAP-55681

Description

To support the 3rd party models it's required to:

  • bump lightspeed-core-stack to 0.3.0
  • bump lightspeed-providers to 0.1.6

Testing

Steps to test

  1. Pull down the PR
  2. make clean
  3. make run
  4. open the chatbot and send prompts asking about Ansible/AAP

Scenarios tested

I run the chatbox locally with Granite 3.3 and asked at least 20 questions about AAP, playbooks, how to automate things... All the responses were as expected.

Production deployment

  • This code change is ready for production on its own
  • This code change requires the following considerations before going to production:

@de1987 de1987 self-assigned this Oct 15, 2025
user_data_collection:
feedback_disabled: true
transcripts_disabled: true
user_data_collection: {}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we clearing these true?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jameswnl Pydantic is blocking both fields to change.
I will check if there is a way to set it in a different way

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jameswnl so they changed the fields, I will push the changes to add these again
I check if the changes hasn't impact the chatbot

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jameswnl done and verified

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so the setting fields are the opposite now:

  feedback_enabled: false
  transcripts_enabled: false

type: sqlite
namespace: null
db_path: ${env.PROVIDERS_DB_DIR:=/.llama/data/distributions/ansible-chatbot}/localfs_datasetio.db
files:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this files is missing in the apis section, expected?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jameswnl yes, that required now, that why we added these

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to add an entry of files to the section from Line 4 - 11?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch! I will add it
the weird part that LCS hasn't complained about it

fyi, the error I got

RuntimeError: Failed to resolve 'tool_runtime' provider 'rag-runtime' of type 'inline::rag-runtime': required dependency 'files' is not available. Please add a 'files' provider to your configuration or check if the provider is properly configured.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added it in the apis

bump lightspeed-providers to 0.1.6
@de1987 de1987 force-pushed the aap-55681-bump-lcs-and-lightspeed-providers branch from 3d164ad to 37d526e Compare October 16, 2025 17:16
@de1987 de1987 requested a review from jameswnl October 16, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants