-
Notifications
You must be signed in to change notification settings - Fork 14
AAP-55681: Bump lightspeed-core-stack and lightspeed-providers #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
AAP-55681: Bump lightspeed-core-stack and lightspeed-providers #107
Conversation
lightspeed-stack-mcp.yaml
Outdated
user_data_collection: | ||
feedback_disabled: true | ||
transcripts_disabled: true | ||
user_data_collection: {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are we clearing these true
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jameswnl Pydantic is blocking both fields to change.
I will check if there is a way to set it in a different way
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jameswnl so they changed the fields, I will push the changes to add these again
I check if the changes hasn't impact the chatbot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jameswnl done and verified
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so the setting fields are the opposite now:
feedback_enabled: false
transcripts_enabled: false
type: sqlite | ||
namespace: null | ||
db_path: ${env.PROVIDERS_DB_DIR:=/.llama/data/distributions/ansible-chatbot}/localfs_datasetio.db | ||
files: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this files
is missing in the apis
section, expected?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jameswnl yes, that required now, that why we added these
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to add an entry of files
to the section from Line 4 - 11?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch! I will add it
the weird part that LCS hasn't complained about it
fyi, the error I got
RuntimeError: Failed to resolve 'tool_runtime' provider 'rag-runtime' of type 'inline::rag-runtime': required dependency 'files' is not available. Please add a 'files' provider to your configuration or check if the provider is properly configured.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added it in the apis
bump lightspeed-providers to 0.1.6
3d164ad
to
37d526e
Compare
Jira Issue: AAP-55681
Description
To support the 3rd party models it's required to:
lightspeed-core-stack
to 0.3.0lightspeed-providers
to 0.1.6Testing
Steps to test
make clean
make run
Scenarios tested
I run the chatbox locally with Granite 3.3 and asked at least 20 questions about AAP, playbooks, how to automate things... All the responses were as expected.
Production deployment