Skip to content

Conversation

AlanCoding
Copy link
Member

@AlanCoding AlanCoding commented Oct 15, 2025

Description

ran:

cd requirements/
./updater.sh upgrade

and we'll see what happens.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Test update
  • Refactoring (no functional changes)
  • Development environment change
  • Configuration change

Note

Adds a new py312-in-files tox/CI environment using .in requirements, upgrades/refreshes dependencies, pins djangorestframework<3.16, loosens some dev constraints, and tightens an OAuth2 application validation test.

  • CI/Build:
    • Add tox env py312-in-files loading multiple .in requirement files and include it in the GitHub Actions matrix.
    • Update tox config in pyproject.toml to define the new env.
  • Dependencies:
    • Broad upgrade of pinned packages in requirements/requirements_all.txt (e.g., asgiref, channels, cryptography, lxml, redis, etc.).
    • Pin djangorestframework<3.16 in requirements.in.
    • Relax dev constraints in requirements_dev.txt (django<6, sqlparse<1).
  • Tests:
    • Update OAuth2 application validator test to assert organization field is required.

Written by Cursor Bugbot for commit 13ec8e2. This will update automatically on new commits. Configure here.

@AlanCoding
Copy link
Member Author

Got this one failure. I really don't know why.

__________________ test_oauth2_provider_application_validator __________________
[gw2] linux -- Python 3.10.18 /home/runner/work/django-ansible-base/django-ansible-base/.tox/py310/bin/python

admin_api_client = <rest_framework.test.APIClient object at 0x7fc015bdc0d0>

    def test_oauth2_provider_application_validator(admin_api_client):
        """
        If we don't get enough information in the request, we should 400
        """
        url = get_relative_url("application-list")
        response = admin_api_client.post(
            url,
            data={
                'name': 'test app',
                'authorization_grant_type': 'authorization-code',
                'client_type': 'confidential',
            },
        )
>       assert response.status_code == 400
E       assert 201 == 400
E        +  where 201 = <Response status_code=201, "application/json">.status_code

test_app/tests/oauth2_provider/views/test_application.py:204: AssertionError

@AlanCoding
Copy link
Member Author

^ It's DRF

@AlanCoding
Copy link
Member Author

I can't fix the DRF issue, so I pinned it. Someone else will need to address it.

@AlanCoding AlanCoding marked this pull request as ready for review October 15, 2025 18:50
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

dev constraint

Add DRF pin

Add a new check
@AlanCoding AlanCoding changed the title General dependency upgrade AAP-56257 General dependency upgrade Oct 17, 2025
@github-actions
Copy link

DVCS PR Check Results:

PR appears valid (JIRA key(s) found)

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant