AAP-56394 Fix SAML authentication uid selection #871
Merged
+25
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-westcott-iv
approved these changes
Oct 22, 2025
- Add parameterized test for determine_username_from_uid_social function - Cover both SAML (uses uid) and non-SAML (uses details.username) branches - Test multiple authenticator types: SAML, LDAP, OIDC, Keycloak - Ensures comprehensive coverage of lines 140-143 in authentication.py Co-authored-by: Claude <claude@anthropic.com>
|
DVCS PR Check Results: PR appears valid (JIRA key(s) found) |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The determine_username_from_uid_social pipeline was selecting the 'username' value from the pipeline kwargs/details, which is generally correct for most authenticators, however for SAML specifically the 'uid' is not the exact username, but the username prepended with 'IdP:' (hard coded for our SAML authenticators). The incorrect use of 'username' was causing the AuthenticatorUser not to be found. This was OK in the case that another user didn't exist with the same email, but if such a user does exist, the authentication process errors out with a "more than one user found" error, blocking the SAML user from logging in permanently unless the "conflicting" local user was removed.
Type of Change
Self-Review Checklist
Testing Instructions
Prerequisites
Steps to Test
Expected Results
see above