Skip to content

Conversation

@Jakuje
Copy link
Contributor

@Jakuje Jakuje commented Jun 10, 2025

SUMMARY

This also changes the way how the libssh finds the OpenSSL installation to use the OPENSSL_ROOT_DIR variable.

Based partially on the changes in #719 and from the https://github.com/pyca/infra/tree/main/cryptography-linux

ISSUE TYPE
  • Feature Pull Request

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jun 10, 2025
@packit-as-a-service
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/ansible-pylibssh-738
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@Jakuje Jakuje force-pushed the openssl-3.5.0 branch 5 times, most recently from 0371ac8 to ab8c4be Compare June 10, 2025 10:40
@Jakuje
Copy link
Contributor Author

Jakuje commented Jun 10, 2025

The s390x issue was fixed with the suggestion from openssl/openssl#27323 -- should have mentioned in the commit message. If it will work, I can amend.

pushd openssl-${OPENSSL_VERSION}
pushd ${OPENSSL_VERSION}
BUILD_FLAGS="$OPENSSL_BUILD_FLAGS"
if [[ "$1" =~ '^manylinux1_.*$' ]]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side note: we should drop this in a separate PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to move it into separate issue or should I create separate PR with this right away? I think also the perl installation can be dropped now, when we install perl from RPM.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, there's a number of compatibility fallbacks that I haven't removed while dropping older manylinux base images. Feel free to look into this whenever. But it doesn't block anything, so there's no rush, really. I just posted the note for myself.

This also changes the way how the libssh finds the OpenSSL installation
to use the `OPENSSL_ROOT_DIR` variable.

Based partially on the changes in ansible#719, partially on current version of
https://github.com/pyca/infra/tree/main/cryptography-linux

The s390x issue was fixed with the suggestion from openssl/openssl#27323

The new openssl build takes longer (especially on ppc64le) so bumping
the timeout to 50 minutes.

Signed-off-by: Jakub Jelen <jjelen@redhat.com>
@sonarqubecloud
Copy link

@webknjaz webknjaz enabled auto-merge June 10, 2025 17:17
@webknjaz webknjaz merged commit 7d8d851 into ansible:devel Jun 10, 2025
157 of 162 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants