-
-
Notifications
You must be signed in to change notification settings - Fork 35
🧪 Add Ubuntu on ARM into the CI matrix #761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: devel
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds Ubuntu on ARM virtual machines to the CI testing matrix to ensure ARM distributions are properly tested alongside the existing x86_64 builds. The change expands test coverage by including ARM architecture testing in the GitHub Actions workflow.
- Adds
ubuntu-24.04-armto the CI matrix runner configurations - Includes changelog documentation for the enhancement
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/ci-cd.yml | Adds ubuntu-24.04-arm to the runner-vm-os matrix |
| docs/changelog-fragments/674.contrib.rst | Documents the CI enhancement with ARM Ubuntu VM testing |
| docs/changelog-fragments/761.contrib.rst | Contains incorrect filename reference for changelog fragment |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
3a53468 to
c227541
Compare
|
I accidentally pushed a43317f directly to |
|
The Thread 0x0000ff4b189205e0 (most recent call first):
File "/opt/hostedtoolcache/Python/3.11.13/arm64/lib/python3.11/subprocess.py", line 2011 in _try_wait
File "/opt/hostedtoolcache/Python/3.11.13/arm64/lib/python3.11/subprocess.py", line 2053 in _wait
File "/opt/hostedtoolcache/Python/3.11.13/arm64/lib/python3.11/subprocess.py", line 1264 in wait
File "/opt/hostedtoolcache/Python/3.11.13/arm64/lib/python3.11/subprocess.py", line 391 in call
File "/opt/hostedtoolcache/Python/3.11.13/arm64/lib/python3.11/subprocess.py", line 408 in check_call
File "/home/runner/work/pylibssh/pylibssh/tests/conftest.py", line 104 in ssh_clientkey_path
[...](https://github.com/ansible/pylibssh/actions/runs/17129398870/job/48589807624?pr=761#step:16:41) |
The respective dists are being built already. This patch moves building to faster native ARM runners and makes sure they are also tested.
Resolves #674.