Skip to content

Conversation

@webknjaz
Copy link
Member

@webknjaz webknjaz commented Aug 21, 2025

The respective dists are being built already. This patch moves building to faster native ARM runners and makes sure they are also tested.

Resolves #674.

@webknjaz webknjaz self-assigned this Aug 21, 2025
@webknjaz webknjaz added the github_actions Pull requests that update Github_actions code label Aug 21, 2025
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Aug 21, 2025
webknjaz added a commit to webknjaz/ansible--pylibssh that referenced this pull request Aug 21, 2025
@webknjaz webknjaz marked this pull request as ready for review August 21, 2025 13:24
@Copilot Copilot AI review requested due to automatic review settings August 21, 2025 13:24
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds Ubuntu on ARM virtual machines to the CI testing matrix to ensure ARM distributions are properly tested alongside the existing x86_64 builds. The change expands test coverage by including ARM architecture testing in the GitHub Actions workflow.

  • Adds ubuntu-24.04-arm to the CI matrix runner configurations
  • Includes changelog documentation for the enhancement

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/ci-cd.yml Adds ubuntu-24.04-arm to the runner-vm-os matrix
docs/changelog-fragments/674.contrib.rst Documents the CI enhancement with ARM Ubuntu VM testing
docs/changelog-fragments/761.contrib.rst Contains incorrect filename reference for changelog fragment

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@packit-as-a-service

This comment was marked as outdated.

@webknjaz

This comment was marked as resolved.

@webknjaz webknjaz force-pushed the maintenance/gha-ubuntu-on-arm branch from 3a53468 to c227541 Compare August 21, 2025 14:08
@webknjaz
Copy link
Member Author

I accidentally pushed a43317f directly to devel. So I rebased this one on top.

@webknjaz
Copy link
Member Author

The ssh_clientkey_path fixture is possibly being slow due to ssh-keygen -b 8192 hanging for noticable amount of time.

Thread 0x0000ff4b189205e0 (most recent call first):
  File "/opt/hostedtoolcache/Python/3.11.13/arm64/lib/python3.11/subprocess.py", line 2011 in _try_wait
  File "/opt/hostedtoolcache/Python/3.11.13/arm64/lib/python3.11/subprocess.py", line 2053 in _wait
  File "/opt/hostedtoolcache/Python/3.11.13/arm64/lib/python3.11/subprocess.py", line 1264 in wait
  File "/opt/hostedtoolcache/Python/3.11.13/arm64/lib/python3.11/subprocess.py", line 391 in call
  File "/opt/hostedtoolcache/Python/3.11.13/arm64/lib/python3.11/subprocess.py", line 408 in check_call
  File "/home/runner/work/pylibssh/pylibssh/tests/conftest.py", line 104 in ssh_clientkey_path
[...]

(https://github.com/ansible/pylibssh/actions/runs/17129398870/job/48589807624?pr=761#step:16:41)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:provided There is a change note present in this PR github_actions Pull requests that update Github_actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] Integrate Linux ARM jobs

1 participant