📦Only enable line tracing when w/Cython tracing #778
+45
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch modifies the build backend to dynamically enable Cython line tracing only when explicitly requested via the
with-cython-tracing=trueconfig setting. Previously, havinglinetrace = "True"inpyproject.tomlwas making our PyPI-published wheels slower.Now, line tracing is opt-in:
Regular builds:
pip install .(no line tracing)Tracing builds:
pip install . --config-setting=with-cython-tracing=true(enables line tracing)
When tracing is requested, the build backend automatically adds the
linetrace=Trueandprofile=TrueCython directives and sets the appropriate C compiler flags.Resolves #767
ISSUE TYPE
BLOCKERS