Skip to content

Update .save() calls with UserRoleModel.create() #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abhishek-nexgen-dev wants to merge 2 commits into
base: dev
Choose a base branch
from
+40 −9
Open

Update .save() calls with UserRoleModel.create() #143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba4859d
refactor(user): update user creation logic to use UserModel.create
abhishek-nexgen-dev Oct 17, 2025
4849779
refactor(user): update user creation logic to use UserModel.create
abhishek-nexgen-dev Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 38 additions & 7 deletions .env.example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ APP_PORT=8000 # Port number for the applicati
PINO_LOG_LEVEL=info # Log level (trace/debug/info/warn/error/fatal)

# Database Configuration
DATABASE_URI=mongodb://localhost:27017/ # MongoDB connection URL
DATABASE_URI=mongodb://localhost:27017/user-service # MongoDB connection URL
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There's an inconsistency between the database name in DATABASE_URI (user-service) and the DB_NAME variable on the next line (users-service). While the dbName option in the Mongoose connection options will likely override the one in the URI, it's best to keep these consistent to avoid confusion. I'd recommend making them match.

DATABASE_URI=mongodb://localhost:27017/users-service          # MongoDB connection URL

Copy link
Collaborator

@sanjaysah101 sanjaysah101 Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @abhishek-nexgen-dev, since we have already DB_NAME in env. we don't need to update DB_URI

DB_NAME=users-service

# Redis connection
Expand Down Expand Up @@ -43,11 +43,42 @@ CLIENT_URL=http://localhost:3000 # Frontend client URL

# JWT RSA Keys (Replace with actual RSA keys)
PRIVATE_KEY="-----BEGIN PRIVATE KEY-----
MIIEvQIBADANBgkqhkiG9w0BAQEFAASCBKcwggSjAgEAAoIBAQCh2omMxTPcCcNk
... (rest of private key) ...
-----END PRIVATE KEY-----"
MIIEvQIBADANBgkqhkiG9w0BAQEFAASCBKcwggSjAgEAAoIBAQC8QMjlH9vP4foj
qu9jO/oG2s327nY/her1FjQfOX0mLHNPrEOhi3ONVa1TE1znGhxR/Fs2SPofFBp7
lG9lIV/Seh45zeIYgyQJh/WjB1Xm4ieig3LGiVCrGJEl4tvXzFBoxvK3XEL9HrHR
aC5I1uZCedk206GkbEGpthMtKuZYoAAzySz9LUi3SCEFzZ6+Qi9dbeUK2OBlD87V
zl0itshA2Xkp7cOGSCmTvI/A9CSk9mCxWi81dAgvMyQ0sd9+QnxR9pQoqVdc4vAy
c4Z9GI4Y3xpaxB8AlAczwGRO9vWY6RmruKucIEUmel9U7uXzxKKRsdhGa5UCPmvZ
7xZMVZ1ZAgMBAAECggEAAmTTASnhbFBv8zvpWSJSPLvTzmnsHkTsTtNKVKLRIvcB
/N+AiSl6LdAK+RFYFza7aTX7rXIqXxKM/ykNLRSqcKVdpMfH0h65yra8QodVee8C
iMQh5aEpodFZSCltOP5nv9tWywrc7bXSFkr8OrAj47DDuLkidzIquBchAYwn+3TA
z2TFQwlT+1a87IVwxwSkilRD9OpryWRS4BUBptpRIPLhkzT4x6GiWmKNe/p5oUdB
NqCJgwzt93FNe7VezuupyCkze6rX2w4y5R4G6Zf37ZoG+1XR1mqWb/RCqXGdwSkz
Pttp2OgRBQpuVmElYwFo7qcqijYsbRdEQkCIDmZHgQKBgQDqwxqAsaMdwOhYRnov
JI4wlgV1GcsZidW+y28wiVqJZ6pGs3A8SGHdGaerHByqZTSlshfWIcFLc4pY15Aa
bnBQau3+GW8XBcR1L8q9BQ4cpcNIg35+kBmuVkaopMlxm57P7HoO8m+zTmmbRNA5
ieou+QAdOqEB/EW6lbecNK/92QKBgQDNSJHnS6CWMgQCQ81zOPbntdfH2yCu6j60
GyZPxst9jDF0jqqwQfUztEid+110GrMac9+8xROv6LHDkMiuWyDdIA9WoLubfXZG
E9jkANnwkGuL/6ak3AP47xPxSFSyjtUz4YYL4W6MNHdnKNCa7yg6DovPlpK9VWVx
ju1P89VrgQKBgHVt7n3dXWhurEorxsZ6FJ39DPHMWymFJuPvQskWi7Ebp7MB4uxk
kH9Wa+ZNg5FAWptfgEjeTZ/+RX+3JB/0ij3PnwhxlH4BpomvxEvUkYCG8i39iHKq
hg4Mnf+Rnioz27bJ5SxA3NrmKDFAtJ9zey7P4ty8DPm/ROnWJif+uuHRAoGAWSSZ
TzJVIsPHX+BnmBB1j3s0n7H1SF+qKPXdNilidjtpwm6timqp+vDf09Ky61cozWTi
FIwUF4BZqU33B1fFNqDUaE7WCRh7QsUdmy0PdtqQCTRT/iUYiIHxTAaX2Q4TYTse
xYv4QGQMMbzUkWMnOcbVSajeQd+SdLSXMu/0joECgYEAwTo6KsGqU+utyFPY4rx1
Fmbp/OmyRjCWGBYiaJzGj/VwxDd+HeFcSP7mCQgIyPauTWu6G3YhBk9ckEJrPSmn
/DXqfiexhDoo0oyUM4RfZs1CM980OPT25bHhr2/O6YLmlgwR8G50/tE2NObyi5mK
0+yv7vLxii7GO+XT7Fm9xOQ=
-----END PRIVATE KEY-----
"

PUBLIC_KEY="-----BEGIN PUBLIC KEY-----
MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA0vx7agoebGcQSuuPiLJX
... (rest of public key) ...
-----END PUBLIC KEY-----"
MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAvEDI5R/bz+H6I6rvYzv6
BtrN9u52P4Xq9RY0Hzl9JixzT6xDoYtzjVWtUxNc5xocUfxbNkj6HxQae5RvZSFf
0noeOc3iGIMkCYf1owdV5uInooNyxolQqxiRJeLb18xQaMbyt1xC/R6x0WguSNbm
QnnZNtOhpGxBqbYTLSrmWKAAM8ks/S1It0ghBc2evkIvXW3lCtjgZQ/O1c5dIrbI
QNl5Ke3Dhkgpk7yPwPQkpPZgsVovNXQILzMkNLHffkJ8UfaUKKlXXOLwMnOGfRiO
GN8aWsQfAJQHM8BkTvb1mOkZq7irnCBFJnpfVO7l88SikbHYRmuVAj5r2e8WTFWd
WQIDAQAB
-----END PUBLIC KEY-----
"
4 changes: 2 additions & 2 deletions src/api/v1/user/user.dal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ import { UserModel } from "./user.model.js";

export class UserDAL {
static async createUser(userData: RegisterSchema): Promise<User> {
const newUser = new UserModel(userData);
return await newUser.save();
const userRole = await UserModel.create(userData);
return userRole;
Comment on lines +14 to +15
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The variable name userRole is misleading here, as this function creates a User object, not a UserRole. A more appropriate name would be user or createdUser. Additionally, these two lines can be simplified into a single return statement.

Suggested change
const userRole = await UserModel.create(userData);
return userRole;
return UserModel.create(userData);

}

static async getAllUsers(limit: number, offset: number): Promise<{ users: User[]; totalUsers: number }> {
Expand Down