Skip to content

Conversation

@Revathyvenugopal162
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the enhancement General improvements to existing features label Sep 30, 2025
@github-actions github-actions bot added the ci Pipelines maintenance related label Sep 30, 2025
@github-actions
Copy link

The documentation for this pull request will be available at https://sphinxdocs.ansys.com/pull/804. Please allow some time for the documentation to be deployed.

Copy link
Member

@jorgepiloto jorgepiloto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing. Thanks for adding these to the library, @Revathyvenugopal162. I left some comments, mainly focused on Tox and the new dependencies and scripts added in the package.json file.

Copy link
Member

@jorgepiloto jorgepiloto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! Just making sure we use the latest version for the actions in CI/CD and that commands are cross-platform.

description = Checks for project unit tests and coverage (if desired)
basepython =
{code-style,doc-style,doc-links,doc-html}: python3
description = Run BackstopJS visual regression tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This command is not cross-platform yet. We need to ensure it runs no matter the platform.

I understand the goal is to serve the pages in the local machine and then run the tests against them.

We can explore if Tox supports parallel commands or we can achieve something similar to that.

@jorgepiloto
Copy link
Member

I'll fix the Tox suggestions so we can merge this. No worries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Pipelines maintenance related enhancement General improvements to existing features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants