-
Notifications
You must be signed in to change notification settings - Fork 8
feat: add backstop js test #804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The documentation for this pull request will be available at https://sphinxdocs.ansys.com/pull/804. Please allow some time for the documentation to be deployed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is amazing. Thanks for adding these to the library, @Revathyvenugopal162. I left some comments, mainly focused on Tox and the new dependencies and scripts added in the package.json file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there! Just making sure we use the latest version for the actions in CI/CD and that commands are cross-platform.
| description = Checks for project unit tests and coverage (if desired) | ||
| basepython = | ||
| {code-style,doc-style,doc-links,doc-html}: python3 | ||
| description = Run BackstopJS visual regression tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This command is not cross-platform yet. We need to ensure it runs no matter the platform.
I understand the goal is to serve the pages in the local machine and then run the tests against them.
We can explore if Tox supports parallel commands or we can achieve something similar to that.
|
I'll fix the Tox suggestions so we can merge this. No worries. |
No description provided.