Skip to content

Conversation

SMoraisAnsys
Copy link
Collaborator

Description

Follow up of #5488 where a part of the changes broke an example, see ansys/pyaedt-examples#287
Note that the changes from props to properties make total sense so I applied the same logic on other classes.
Among changes, I also added documentation improvements.

Issue linked

ansys/pyaedt-examples#287

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

❌ Patch coverage is 55.20833% with 43 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.81%. Comparing base (3a67112) to head (05b719f).
⚠️ Report is 647 commits behind head on main.

❌ Your patch status has failed because the patch coverage (55.20%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5584       +/-   ##
===========================================
- Coverage   85.26%   17.81%   -67.45%     
===========================================
  Files         152      152               
  Lines       61016    61110       +94     
===========================================
- Hits        52025    10887    -41138     
- Misses       8991    50223    +41232     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @SMoraisAnsys

@github-actions github-actions bot added the testing Anything related to testing label Jan 2, 2025
@SMoraisAnsys SMoraisAnsys deleted the refactor/change-props-into-properties branch October 16, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Anything related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants