Skip to content

Conversation

jvela018
Copy link
Contributor

@jvela018 jvela018 commented Oct 2, 2025

Description

Use solution_type in create_output_variable method when calling the native API

Issue linked

#6724

@jvela018 jvela018 requested a review from a team as a code owner October 2, 2025 09:49
@jvela018 jvela018 linked an issue Oct 2, 2025 that may be closed by this pull request
2 tasks
@jvela018 jvela018 self-assigned this Oct 2, 2025
Copy link

codecov bot commented Oct 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.27%. Comparing base (51db8e6) to head (113ef80).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6726   +/-   ##
=======================================
  Coverage   83.26%   83.27%           
=======================================
  Files         246      246           
  Lines       77487    77487           
=======================================
+ Hits        64522    64529    +7     
+ Misses      12965    12958    -7     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@gmalinve gmalinve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comment :)

gmalinve
gmalinve previously approved these changes Oct 2, 2025
@jvela018 jvela018 requested a review from gmalinve October 3, 2025 18:32
@jvela018
Copy link
Contributor Author

@gmalinve ,

I've tested this branch in the resistance.py example in 2024R2, 2025R1 and 2025R2. Will you please approve? Thanks

@gmalinve gmalinve marked this pull request as draft October 13, 2025 13:05
@jvela018 jvela018 changed the title FIX: Use solution type instead of report type in CreateOutputVariable FIX: Update Report type according to Solution Type in CreateOutputVariable Oct 14, 2025
@gmalinve gmalinve marked this pull request as ready for review October 14, 2025 13:26
@gmalinve gmalinve marked this pull request as draft October 14, 2025 13:45
@jvela018 jvela018 marked this pull request as ready for review October 15, 2025 08:01
@gmalinve gmalinve marked this pull request as draft October 15, 2025 08:20
@gmalinve gmalinve marked this pull request as ready for review October 16, 2025 19:29
Copy link
Contributor

@gmalinve gmalinve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmalinve gmalinve merged commit e185a86 into main Oct 17, 2025
41 of 63 checks passed
@gmalinve gmalinve deleted the jv/fix/create_output_variable branch October 17, 2025 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

create_output_variable doesn't work in Maxwell

4 participants