Skip to content

Conversation

eblanco-ansys
Copy link
Contributor

Update the design type check to include "Maxwell 2D" and modify the points cloud extension call to use a the new extension data class

@eblanco-ansys eblanco-ansys requested a review from a team as a code owner October 10, 2025 13:05
@eblanco-ansys eblanco-ansys enabled auto-merge (squash) October 10, 2025 13:05
@eblanco-ansys eblanco-ansys self-assigned this Oct 10, 2025
@github-actions github-actions bot added the bug Something isn't working label Oct 10, 2025
gmalinve
gmalinve previously approved these changes Oct 10, 2025
Copy link
Contributor

@gmalinve gmalinve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks very much!!!

Copy link

codecov bot commented Oct 10, 2025

Codecov Report

❌ Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.22%. Comparing base (0a75871) to head (208d608).
⚠️ Report is 2 commits behind head on main.

❌ Your patch status has failed because the patch coverage (25.00%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6750      +/-   ##
==========================================
- Coverage   83.23%   83.22%   -0.01%     
==========================================
  Files         245      245              
  Lines       77361    77363       +2     
==========================================
- Hits        64389    64387       -2     
- Misses      12972    12976       +4     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@eblanco-ansys eblanco-ansys merged commit 8a6552a into main Oct 10, 2025
151 of 159 checks passed
@eblanco-ansys eblanco-ansys deleted the fix/point-cloud-maxwell2D-design-type branch October 10, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants