-
Notifications
You must be signed in to change notification settings - Fork 57
feat: Implement named-object commands using root-level commands #4398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mkundu1
wants to merge
6
commits into
main
Choose a base branch
from
feat/named-object-commands
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+38
−2
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
4fc892a
feat: Implement named-object commands using root-level commands
mkundu1 5a10998
feat: Add _has_migration_adapter bool to flobject class
mkundu1 9052242
chore: adding changelog file 4398.added.md [dependabot-skip]
pyansys-ci-bot 4d5b15a
fix: tests
mkundu1 4305a7e
fix: tests
mkundu1 ffab786
test: remove a temp code
mkundu1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Implement named-object commands using root-level commands |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1501,6 +1501,21 @@ def __add__(self, other): | |
) | ||
return CombinedNamedObject([self, other]) | ||
|
||
def list(self): | ||
"""Print the object names.""" | ||
return self._root.list(object_path=self.path) | ||
|
||
def list_properties(self, object_name): | ||
"""Print the properties of the given object name. | ||
|
||
Parameters | ||
---------- | ||
object_name : str | ||
Name of the object whose properties are to be listed. | ||
""" | ||
# The generated parameter name is path_1 as the name path clashes with existing property. | ||
return self._root.list_properties(path_1=self.path, name=object_name) | ||
|
||
|
||
class CombinedNamedObject: | ||
"""A ``CombinedNamedObject`` contains the concatenated named-objects.""" | ||
|
@@ -1762,6 +1777,8 @@ def _execute_command(self, *args, **kwds): | |
else: | ||
print("Please enter 'y[es]' or 'n[o]'.") | ||
with self._while_executing_command(): | ||
if "path" in kwds: | ||
kwds["path_1"] = kwds.pop("path") | ||
Comment on lines
+1780
to
+1781
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This parameter renaming logic is duplicated in the settings.py file but in reverse. Consider extracting this logic into a utility function to avoid code duplication and ensure consistency. Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||
ret = self.flproxy.execute_cmd(self._parent.path, self.obj_name, **kwds) | ||
if ( | ||
not config.disable_parameter_list_return_fix | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment refers to 'generated parameter name' but this is manually written code. The comment should clarify that path_1 is used to avoid conflict with the existing path property, and explain the parameter renaming mechanism.
Copilot uses AI. Check for mistakes.