-
Notifications
You must be signed in to change notification settings - Fork 5
feat: add thermic source #651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
# Conflicts: # pyproject.toml
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #651 +/- ##
==========================================
- Coverage 88.80% 88.65% -0.15%
==========================================
Files 39 39
Lines 5634 5702 +68
==========================================
+ Hits 5003 5055 +52
- Misses 631 647 +16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
use pathlib rather than os.path
@@ -0,0 +1,20 @@ | |||
from pathlib import Path |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please consider refactor this into unittest or example.
if needed, add the speos file used into the tests/assert folder
for more information, see https://pre-commit.ci
Description
Add thermic source in core layer inside the core.source module
Follow the existing architectural structure, using current source implementations as reference.
Ensure default values are consistent with SCDM Speos standards.
Documentation
Provide a usage example in the core module’s documentation, demonstrating how to initialize and use the new ambient source.
Testing
Create a unit test for the thermic source functionality within the core module to ensure stability and correctness.
Issue linked
Add Thermic source in core layer #540
Checklist
feat: add optical property
)