Skip to content

Implement one token by streamId for reconnection #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sylvainf911 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Implement one token by streamId for reconnection #547

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3062ed0
Implement one token by streamId for reconnection
sylvainf911 May 30, 2025
41ae83a
Merge branch 'master' into fix-reconnect-tokens
sylvainf911 Jun 16, 2025
6d716ea
Merge branch 'master' into fix-reconnect-tokens
sylvainf911 Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/main/js/webrtc_adaptor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,7 @@ export class WebRTCAdaptor {
/**
* This is the token to play the stream. It's added here to use in reconnect scenario
*/
this.playToken = null;
this.playTokens = new Map();

/**
* This is the room id to play the stream. It's added here to use in reconnect scenario
Expand Down Expand Up @@ -670,7 +670,7 @@ export class WebRTCAdaptor {
}

this.playStreamId.push(streamId);
this.playToken = token;
this.playTokens.set(streamId, token);
this.playRoomId = roomId;
this.playEnableTracks = enableTracks;
this.playSubscriberId = subscriberId;
Expand Down Expand Up @@ -771,12 +771,13 @@ export class WebRTCAdaptor {
this.notifyEventListeners("reconnection_attempt_for_player", streamId);

Logger.log("It will try to play again for stream: " + streamId + " because it is not stopped on purpose")
const token = this.playTokens.get(streamId);
this.stop(streamId);
setTimeout(() => {
//play about some time later because server may not drop the connection yet
//it may trigger already playing error
Logger.log("Trying play again for stream: " + streamId);
this.play(streamId, this.playToken, this.playRoomId, this.playEnableTracks, this.playSubscriberId, this.playSubscriberCode, this.playMetaData, this.playRole);
this.play(streamId, token, this.playRoomId, this.playEnableTracks, this.playSubscriberId, this.playSubscriberCode, this.playMetaData, this.playRole);
}, 500);
}
}
Expand Down Expand Up @@ -1303,6 +1304,7 @@ export class WebRTCAdaptor {
var playStreamIndex = this.playStreamId.indexOf(streamId);
if (playStreamIndex != -1) {
this.playStreamId.splice(playStreamIndex, 1);
this.playTokens.delete(streamId);
}
}
//this is for the stats
Expand Down