Add support for passList, private output#13
Open
Chris-dash-T4 wants to merge 5 commits intoanthonywu:mainfrom
Open
Add support for passList, private output#13Chris-dash-T4 wants to merge 5 commits intoanthonywu:mainfrom
Chris-dash-T4 wants to merge 5 commits intoanthonywu:mainfrom
Conversation
Owner
|
oh hi there! the rare contribution I am just seeing this, promsie will take a look soon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
High-level summary
passListfor non-BART transit passesCode changes (AI summary)
1. CLI/workflow change
--show-privateflag to thesummarycommand.clippercard.porcelain.tabular_output(...).logging.basicConfig(level=logging.INFO)call (overriding later debug flag).2. Dashboard parsing contract
parse_dashboard_cards(...)to parse a newpassListstructure from dashboard JSON/HTML.passListnow becomes aCardProductwith:name="Pass"valuecontaining the pass description and expiration dateparse_cards(...)helper as deprecated, noting it is legacy and only used in tests.3. Output formatting / private-data contract
tabular_output(...)now acceptsshow_private=Falseby default.show_private=False, it redacts:name,email,mailing_address,phone_redact_private_info(...)helper for these rules.show_private=Truepreserves the full values (previous default).4. Test coverage updates
passListinto card products.Expires YYYY-MM-DDtabular_output(..., show_private=True).show_private=False.5. Fixture/data structure change
passList.Overall effect
passList.please lmk if there are any changes or suggestions, i hope this will be a helpful addition!