fix(ralph-wiggum): Move multiline bash to setup script #15845
Closed
+28
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Claude Code's safety check blocks bash commands containing newlines. This moves the completion promise display logic from the inline command in ralph-loop.md into setup-ralph-loop.sh, making the command a single line that passes the safety check. Also fixes a pre-existing shellcheck warning about unquoted variable.
Author
|
Hm, I ran into this issue separately after fixing it: #3662 |
delikat
added a commit
to delikat/claude-code
that referenced
this pull request
Dec 31, 2025
Remove ```! code blocks from command files that caused permission check failures. Claude Code's security model rejects multi-line bash commands, and the auto-execute syntax was being included in permission validation. Changes: - Extract multi-line bash from command files to external scripts - Create scripts/cancel-ralph.sh for cancellation logic - Move completion promise display to setup-ralph-loop.sh - Scope allowed-tools to specific script paths for security - Add bash prefix to hooks.json for Windows compatibility - Use #!/usr/bin/env bash for portability across systems - Use heredoc for static text to prevent variable interpolation bugs Based on patterns from PRs anthropics#59, anthropics#58, anthropics#72, anthropics#89, anthropics#15845, anthropics#15731. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
|
having same issue.. |
Contributor
|
Closing in favour of #16320 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ralph-loop.mdintosetup-ralph-loop.shProblem
Claude Code's safety check blocks bash commands containing newlines to prevent command injection. The ralph-loop command had an inline multi-line bash script that triggered this check:
Solution
Move the completion promise display logic into the setup script, which already has access to the
$COMPLETION_PROMISEvariable. This simplifies the command to a single line while maintaining the same functionality.Test plan
setup-ralph-loop.sh/ralph-wiggum:ralph-loopcommand executes without permission error--completion-promiseis set