Skip to content

fix(build): skip rerun-if-changed for .files() in Buf mode #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hobostay wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(build): skip rerun-if-changed for .files() in Buf mode #59

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e79f695
fix(build): skip rerun-if-changed for .files() in Buf mode
hobostay Apr 30, 2026
b95b33f
Merge branch 'main' into fix/build-buf-rerun-if-changed
iainmcgin May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion connectrpc-build/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,12 @@ impl Config {
DescriptorSource::Precompiled(p) => {
println!("cargo:rerun-if-changed={}", p.display());
}
DescriptorSource::Protoc | DescriptorSource::Buf => {
// Both Buf and Precompiled modes use proto-relative names (not
// filesystem paths) in `.files()`. Emitting `rerun-if-changed`
// for those would point cargo at non-existent files and force a
// rebuild every invocation.
DescriptorSource::Buf => {}
DescriptorSource::Protoc => {
for f in &self.files {
println!("cargo:rerun-if-changed={}", f.display());
}
Expand Down