feat(api/ui): set provider and model atomically#2717
Open
tusharmath wants to merge 2 commits intomainfrom
Open
feat(api/ui): set provider and model atomically#2717tusharmath wants to merge 2 commits intomainfrom
tusharmath wants to merge 2 commits intomainfrom
Conversation
tusharmath
commented
Mar 27, 2026
Comment on lines
521
to
529
| Provider { | ||
| /// Provider ID to set as default. | ||
| provider: ProviderId, | ||
|
|
||
| /// Optional model ID to set simultaneously, skipping interactive model | ||
| /// selection. | ||
| /// selection. When omitted, an interactive prompt is shown. | ||
| #[arg(long)] | ||
| model: Option<ModelId>, | ||
| }, |
Collaborator
Author
There was a problem hiding this comment.
model and provider are both required while setting model.
tusharmath
commented
Mar 27, 2026
| # Action handler: Select model (across all configured providers) | ||
| # When the selected model belongs to a different provider, switches it first. | ||
| # Always calls `forge config set provider <provider_id> --model <model_id>` on selection. | ||
| function _forge_action_model() { |
Collaborator
Author
There was a problem hiding this comment.
simplify this logic to simply trigger forge config set model
Which should open the Rust implementation of interactive model setting.
Collaborator
Author
There was a problem hiding this comment.
Need to also drop :provider and use it as an alias to :login which should triggeer forge provider login without any params.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.