fix: surface provider model fetch failures during login; closes #2715#2719
Open
mishl-dev wants to merge 1 commit intoantinomyhq:mainfrom
Open
fix: surface provider model fetch failures during login; closes #2715#2719mishl-dev wants to merge 1 commit intoantinomyhq:mainfrom
mishl-dev wants to merge 1 commit intoantinomyhq:mainfrom
Conversation
Return provider-specific errors when configured providers fail to refresh credentials or fetch models instead of silently skipping them. This keeps OpenAI-compatible and Ollama login/model-selection failures visible to the user instead of degrading into an empty model list.
|
|
mishl-dev
changed the title
tusharmath
reviewed
Mar 27, 2026
| format!("Failed to fetch models for provider '{provider_id}'") | ||
| })?; | ||
|
|
||
| Ok(ProviderModels { provider_id, models }) |
Collaborator
There was a problem hiding this comment.
I don't think this would propagate the errors - it will add more context to the error message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return provider-specific errors when configured providers fail to refresh credentials or fetch models instead of silently skipping them. This keeps OpenAI-compatible and Ollama login/model-selection failures visible to the user instead of degrading into an empty model list.