Skip to content

Add loading skeleton for sidebar #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joshdayorg wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add loading skeleton for sidebar #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 64 additions & 0 deletions app/assets/stylesheets/application/sidebar.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -627,3 +627,67 @@
font-weight: 500;
}
}

/* Sidebar Loading Skeleton */
.sidebar__loading {
padding-inline-end: var(--sidebar-tools-width);
block-size: 100dvh;
}

.sidebar__loading-directs {
display: flex;
gap: calc(var(--inline-space) / 1.5);
padding-block: var(--block-space) var(--block-space-half);
padding-inline: var(--sidebar-inline-space);
margin-block-end: var(--block-space-half);
}

.sidebar__loading-avatar {
width: 48px;
height: 48px;
border-radius: 50%;
background: var(--color-border);
animation: skeleton-pulse 1.5s ease-in-out infinite;
}

.sidebar__loading-rooms {
padding-inline: var(--sidebar-inline-space);
}

.sidebar__loading-search {
height: 2.5rem;
border-radius: 0.5rem;
background: var(--color-border);
margin-block-end: var(--block-space);
animation: skeleton-pulse 1.5s ease-in-out infinite;
}

.sidebar__loading-section {
margin-block-end: var(--block-space);
}

.sidebar__loading-heading {
height: 1.25rem;
width: 6rem;
border-radius: 0.25rem;
background: var(--color-border);
margin-block-end: var(--block-space);
animation: skeleton-pulse 1.5s ease-in-out infinite;
}

.sidebar__loading-room {
height: 2rem;
border-radius: 0.25rem;
background: var(--color-border);
margin-block-end: 0.5rem;
animation: skeleton-pulse 1.5s ease-in-out infinite;
}

@keyframes skeleton-pulse {
0%, 100% {
opacity: 0.4;
}
50% {
opacity: 0.7;
}
}
10 changes: 8 additions & 2 deletions app/helpers/users/sidebar_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,18 @@ def has_unreads?
Current.user.memberships.unread.any?
end

def sidebar_turbo_frame_tag(src: nil, &)
def sidebar_turbo_frame_tag(src: nil, &block)
content = if block_given?
block
elsif src
-> { render "users/sidebars/loading_skeleton" }
end

turbo_frame_tag :user_sidebar, src: src, target: "_top", data: {
controller: "rooms-list read-rooms turbo-frame",
rooms_list_unread_class: "unread",
rooms_list_badge_class: "badge",
action: "presence:present@window->rooms-list#read read-rooms:read->rooms-list#read turbo:frame-load->rooms-list#loaded refresh-room:visible@window->turbo-frame#reload".html_safe # otherwise -> is escaped
}, &
}, &content
end
end
25 changes: 25 additions & 0 deletions app/views/users/sidebars/_loading_skeleton.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
<div class="sidebar__loading">
<div class="sidebar__loading-directs">
<% 5.times do %>
<div class="sidebar__loading-avatar"></div>
<% end %>
</div>

<div class="sidebar__loading-rooms">
<div class="sidebar__loading-search"></div>

<div class="sidebar__loading-section">
<div class="sidebar__loading-heading"></div>
<% 4.times do %>
<div class="sidebar__loading-room"></div>
<% end %>
</div>

<div class="sidebar__loading-section">
<div class="sidebar__loading-heading"></div>
<% 6.times do %>
<div class="sidebar__loading-room"></div>
<% end %>
</div>
</div>
</div>