feat(auth): Add X (Twitter) OAuth integration #37
+217
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements OAuth login and account linking functionality as requested in issue antiwork#20. Features: - X OAuth login on authentication page - X account connection on user profile page - Automatic profile updates with Twitter username and URL - Database migration for Twitter OAuth fields - Proper error handling and security measures Technical implementation: - Added omniauth gems (omniauth, omniauth-twitter2, omniauth-rails_csrf_protection) - Created OauthCallbacksController for handling OAuth callbacks - Added twitter_uid and twitter_username fields to users table - Updated views for login and profile pages - Added environment variables for Twitter API credentials - Included comprehensive setup documentation
Contributor
|
Where are the tests ? Because just by reading the code, i know this implementation is legacy and break stuff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements OAuth login and account linking functionality as requested in issue #20.
Features:
Technical implementation: