Open
Conversation
Member
|
hi @kammoh thanks for the contribution. The changes look good, but it seems that the CI was not triggered in the PR - this is due to misconfiguration in the CI yaml file. This has been fixed on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains 2 separate changes:
sbttomillI have only done very limited simulation test on the changes. I don't think the changes (including port to chisel 6) are likely to break the functionality but nevertheless more extensive testing is recommended.
I understand that the changes should preferably be split into two PRs and that the change of the build system might not be desirable by the maintainers. Unfortunately at this time I won't be able to split the PR. Please feel free to cherry pick, split, or make any changes to this PR!