Add codecov setting for test coverage check#26
Open
wenqiq wants to merge 3 commits intoantrea-io:mainfrom
Open
Add codecov setting for test coverage check#26wenqiq wants to merge 3 commits intoantrea-io:mainfrom
wenqiq wants to merge 3 commits intoantrea-io:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #26 +/- ##
=======================================
Coverage ? 44.03%
=======================================
Files ? 29
Lines ? 12264
Branches ? 0
=======================================
Hits ? 5401
Misses ? 6544
Partials ? 319 |
wenqiq
force-pushed
the
codecov
branch
2 times, most recently
from
fc3dcf5 to
a395e89
Compare
wenqiq
changed the title
wenyingd
reviewed
Sep 15, 2022
| status: | ||
| patch: | ||
| default: | ||
| target: 70% |
There was a problem hiding this comment.
Is 70% coverage required in libOpenflow?
Author
There was a problem hiding this comment.
For each Patch(newly added code lines), 70% coverage is required.
wenqiq
force-pushed
the
codecov
branch
2 times, most recently
from
f94aa1b to
aad5f9b
Compare
Signed-off-by: Wenqi Qiu <wenqiq@vmware.com>
wenqiq
force-pushed
the
codecov
branch
2 times, most recently
from
2da14f2 to
672218f
Compare
wenyingd
reviewed
Oct 13, 2022
Signed-off-by: Wenqi Qiu <wenqiq@vmware.com>
wenyingd
reviewed
Oct 25, 2022
Makefile
Outdated
| .PHONY: test | ||
| test: | ||
| $(GO) test -v ./... | ||
| $(GO) test -v -coverprofile coverage.txt -covermode=atomic -coverpkg=antrea.io/libOpenflow/common/...,antrea.io/libOpenflow/openflow13/...,antrea.io/libOpenflow/openflow15/...,antrea.io/libOpenflow/protocol/...,antrea.io/libOpenflow/util/... antrea.io/libOpenflow/... |
There was a problem hiding this comment.
Maybe remove package antrea.io/libOpenflow/openflow13, which is not maintained in future.
Signed-off-by: Wenqi Qiu <wenqiq@vmware.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add codecov
Signed-off-by: Wenqi Qiu wenqiq@vmware.com