Conversation
|
@antoninbas We found that golangci-bin v1.41.1 may introduce unexpected golint validation failures ( #31 ), so I make this patch to bump up its version to v1.50.0 which is used in antrea. Could you help review it? |
wenyingd
force-pushed
the
bumpup_golangci
branch
from
e18b6b8 to
bc1f1ba
Compare
wenyingd
force-pushed
the
bumpup_golangci
branch
3 times, most recently
from
78eebd8 to
a7a2dc5
Compare
|
Hi @antoninbas , I updated the patch to remove unused code ( all for padding messages), would you help review it again? |
openflow13/action.go
Outdated
| ActionHeader | ||
| MplsTtl uint8 | ||
| pad []byte // 3bytes | ||
| // 3 bytes for padding |
There was a problem hiding this comment.
isn't this comment a bit confusing here, since there is nothing in the struct enforcing that padding?
There was a problem hiding this comment.
I left this comment because the existing code does not provide the necessary implementations of a util.Message, so I want to leave some messages to avoid unexpected mistakes of misunderstanding when implementing the functions in future. In my latest change I add the required implementations, and removed this comment.
openflow13/action.go
Outdated
| ActionHeader | ||
| NwTtl uint8 | ||
| pad []byte // 3bytes | ||
| // 3 bytes for padding |
openflow15/action.go
Outdated
| ActionHeader | ||
| MplsTtl uint8 | ||
| pad []byte // 3bytes | ||
| // 3 bytes for padding |
There was a problem hiding this comment.
ditto, and same for other places below
wenyingd
force-pushed
the
bumpup_golangci
branch
from
a7a2dc5 to
edb40cd
Compare
1. Bump up golangci-bin version to v1.50.0 2. Remove invalid configurations in golangci.yml 3. Formated several files 4. Removed unused code which is for padding messages Signed-off-by: wenyingd <wenyingd@vmware.com>
wenyingd
force-pushed
the
bumpup_golangci
branch
from
edb40cd to
1639eaf
Compare
2 participants
Signed-off-by: wenyingd wenyingd@vmware.com