Skip to content

fix: in g2 v5 container can only be a DOM element or an ID#344

Merged
hustcc merged 4 commits intoantvis:aifrom
larryzhuo:fix/readme_selectorerror
Feb 25, 2026
Merged

fix: in g2 v5 container can only be a DOM element or an ID#344
hustcc merged 4 commits intoantvis:aifrom
larryzhuo:fix/readme_selectorerror

Conversation

@larryzhuo
Copy link
Contributor

@larryzhuo larryzhuo commented Feb 10, 2026

PR includes

Screenshot

Before After

@changeset-bot
Copy link

changeset-bot bot commented Feb 10, 2026

⚠️ No Changeset found

Latest commit: 3916754

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gemini-code-assist
Copy link

Summary of Changes

Hello @larryzhuo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a compatibility issue with @antv/g2 v5 by updating documentation examples. The GPTVis component's container property now expects a DOM element or an ID string directly, rather than a CSS selector. The changes ensure that the provided code examples are correct and functional with the latest version of the underlying charting library.

Highlights

  • Documentation Update for GPTVis Container: Updated the container property usage in GPTVis instantiation examples within README.md and README.zh-CN.md to reflect the new requirement in @antv/g2 v5 where the container must be a DOM element or an ID string, not a CSS selector.
Activity
  • The pull request includes updates to documentation and demos.
  • A visual comparison indicates a fix was successfully applied, changing from a non-working state to a working one.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly updates the container property in the basic usage examples in README.md and README.zh-CN.md to be compatible with G2 v5. However, the change was not applied consistently across all examples in these files. I've left comments pointing out the other occurrences that need to be updated to ensure all code examples are correct and functional for users.

@hustcc hustcc merged commit 6b5f850 into antvis:ai Feb 25, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants