Skip to content

feat: optimize sequence timeline with showStepLabels option #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ooo1l wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: optimize sequence timeline with showStepLabels option #217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 18 additions & 15 deletions src/designs/structures/sequence-timeline.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,13 @@ import type { BaseStructureProps } from './types';
export interface SequenceTimelineProps extends BaseStructureProps {
gap?: number;
lineOffset?: number;
showStepLabels?: boolean;
}

export const SequenceTimeline: ComponentType<SequenceTimelineProps> = (
props,
) => {
const { Title, Item, data, gap = 10, options } = props;
const { Title, Item, data, gap = 10, showStepLabels = true, options } = props;
const { title, desc, items = [] } = data;

const titleContent = Title ? <Title title={title} desc={desc} /> : null;
Expand Down Expand Up @@ -90,20 +91,22 @@ export const SequenceTimeline: ComponentType<SequenceTimelineProps> = (
const nodeY = itemY + itemBounds.height / 2;
const indexes = [index];

decorElements.push(
<Text
x={stepLabelX}
y={nodeY}
width={70}
fontSize={18}
fontWeight="bold"
alignHorizontal="left"
alignVertical="middle"
fill={palette[index % palette.length]}
>
{`STEP ${index + 1}`}
</Text>,
);
if (showStepLabels) {
decorElements.push(
<Text
x={stepLabelX}
y={nodeY}
width={70}
fontSize={18}
fontWeight="bold"
alignHorizontal="left"
alignVertical="middle"
fill={palette[index % palette.length]}
>
{`STEP ${index + 1}`}
</Text>,
);
}

itemElements.push(
<Item
Expand Down
4 changes: 2 additions & 2 deletions src/templates/built-in.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ const BUILT_IN_TEMPLATES: Record<string, TemplateOptions> = {
'sequence-timeline-plain-text': {
design: {
title: 'default',
structure: { type: 'sequence-timeline' },
structure: { type: 'sequence-timeline', showStepLabels: false },
items: [{ type: 'plain-text' }],
},
},
Expand All @@ -231,7 +231,7 @@ const BUILT_IN_TEMPLATES: Record<string, TemplateOptions> = {
'sequence-timeline-simple': {
design: {
title: 'default',
structure: { type: 'sequence-timeline', gap: 20 },
structure: { type: 'sequence-timeline', gap: 20, showStepLabels: false },
items: [{ type: 'simple', positionV: 'middle' }],
},
},
Expand Down