Specify minheap log directory#174
Open
qinsoon wants to merge 3 commits intoanupli:masterfrom
Open
Conversation
caizixian
requested changes
Apr 20, 2026
| with (run_log_dir / "minheap_args.yml").open("w") as fd: | ||
| yaml.dump(args, fd) | ||
| with (run_log_dir / "minheap.yml").open("w") as fd: | ||
| configuration.save_to_file(fd) |
Member
There was a problem hiding this comment.
Configuration needs to be saved before calling resolve_class. Otherwise, the content becomes concrete Python object representing, e.g. BenchmarkSuite, instead of just dictionaries, and the YAML file will contain tags to serialize Python objects.
caizixian
reviewed
Apr 20, 2026
Member
caizixian
left a comment
caizixian
left a comment
There was a problem hiding this comment.
I've pushed a fix. Please take another took.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow optional
--log-dirand-pfor minheap. If log dir is set, logs will be stored in the specified directory. Otherwise, logs are still stored in the temp dir.