This repository was archived by the owner on Feb 25, 2019. It is now read-only.
Fix AD/LDAP group-to-role conversion #285
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`connectUser` is the user object as defined by Anvil Connect, which does not contain `_groups`. `user` is the user object returned by the AD/LDAP client, which contains `_groups`.
Prior, a user with AD/LDAP groups without equivalent roles in Anvil Connect would still have those roles assigned, creating user-to-role relations in the database that referred to non-existent roles. This in turn caused errors elsewhere in the server whenever the roles were enumerated, in particular when attempting to dereference the `name` property of a null role.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #284 and issue described in d5dbcb1