Closed
Conversation
Previously, ripgrep used exit code 2 for all errors - both invalid
arguments (bad patterns, unrecognized flags) and runtime errors (file
not found, permission denied). This made it impossible for callers to
distinguish between the two.
Now:
- Exit code 2: invalid arguments (e.g., literal \n in regex without
--multiline, invalid regex syntax, unrecognized flags)
- Exit code 3: non-fatal runtime errors (e.g., file not found)
The \n-not-allowed-in-regex error (which goes through the fatal Err
path from matcher()) correctly gets exit code 2, classifying it as an
invalid args error rather than a generic 'other error'.
Updated tests to expect exit code 3 for file-not-found scenarios.
Co-authored-by: Jediah Katz <jediahkatz@gmail.com>
|
Cursor Agent can help with this pull request. Just |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change exit codes to differentiate between invalid arguments (2) and non-fatal runtime errors (3), classifying the
\nliteral regex error as an invalid argument.Previously, ripgrep used exit code 2 for all errors, making it impossible to distinguish between invalid arguments and runtime errors. This PR introduces exit code 3 for non-fatal runtime errors (e.g., file not found) while keeping exit code 2 for fatal errors (e.g., invalid regex, unrecognized flags). The
\nliteral regex error is a fatal error (invalid argument) and now correctly returns exit code 2.Slack Thread