Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Signed-off-by: AOXC <aoxcdao@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
aoxchain) with deterministic deployment primitives and a manifest usable by CI/backends.README.Description
src/aoxc-library/includingIAoxcModule,AoxcModuleRegistry,AoxcModuleFactory, example modules, and a thin wrapperAoxcDaoManagerModulethat forwards constructor args to the V2 governance implementation.script/generate_library_manifest.pyproducessrc/aoxc-library/manifest/approved-modules.jsonandscript/validate_library_consumer_config.pyvalidates consumer configs (example:configs/aoxchain.consumer.example.json).docs/AOXCHAIN_*files,src/aoxc-library/README.mdadditions, and Foundry installation/runbook text appended toREADME.mdplusscript/install_foundry.shinstaller.import {X} from ...), added internal helper checks (_onlyOwner,_onlyOperator), tightened integer bounds with explicit checks and safe casts in core modules, and adjusted scripts to useScriptimports; updated tests to useSafeERC20(IERC20(...).safeTransfer(...)) and named imports so the suite compiles against the refactored codepaths.Testing
forge build,forge test, andforge test --fuzz, and exercised the new manifest tooling usingpython3 script/generate_library_manifest.pyandpython3 script/validate_library_consumer_config.py; the automated test runs completed successfully.src/aoxc-library/manifest/approved-modules.jsonis produced byscript/generate_library_manifest.pyand that the example consumer configconfigs/aoxchain.consumer.example.jsonvalidates withscript/validate_library_consumer_config.py.*.s.sol) import and run under the updatedforge-std/Scriptpattern by executing representative script compile checks.Codex Task