refactor: unify internal processing to UTF-8#117
Open
takahashim wants to merge 4 commits intomasterfrom
Open
Conversation
Contributor
Author
|
ファイル自体はShift_JISで扱うようにしつつ、エラーメッセージなどのI18nはCP932で出力できるようにしています |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.to_sjisの扱いがしんどくなっているため、内部エンコーディングを完全にUTF-8に変更します。これまでもコード自体はUTF-8で記述していましたが、実際のデータ等もUTF-8にし、最後に
OutputStreamでShift_JISに変換するようにします。エラーメッセージもUTF-8化した方がいいのかも？と思いましたがこちらは互換性のため変更していません。