Misc improvements #303
Merged
Misc improvements #303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DomGarguilo
commented
Oct 28, 2025
Comment on lines
-66
to
+69
| .peek(entry -> ContinuousWalk.validate(entry.getKey(), entry.getValue())).count(); | ||
| long count = 0; | ||
| for (var entry : scanner) { | ||
| ContinuousWalk.validate(entry.getKey(), entry.getValue()); | ||
| count++; | ||
| } |
Member
Author
There was a problem hiding this comment.
My IDE was warning me that the .peek operation could possibly be optimized out by the compiler so I changed the syntax so that wouldnt happen
| getAuthsMap().put(s, curVal); | ||
| } | ||
| curVal += increment; | ||
| getAuthsMap().merge(s, increment, Integer::sum); |
Member
Author
There was a problem hiding this comment.
This method was not doing anything. I changed the code so that it actually updates the values of the map.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are some pretty trivial, miscellaneous improvements that I saw while working on #302. Some improvements here are: