Fix fateRefs init check when setting the manager state #4180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of apache#4133 the null check for fateRef inside of setManagerState() method in the Manager was inadvertently changed to check if the map size was non empty but the actual check should be that it's null which means not initialized. The map will never be non empty if it is set. This restores the previous check that used to check for a null ref
keith-turner
approved these changes
Jan 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #4133 the null check for fateRef inside of setManagerState() method in the Manager was inadvertently changed to check if the map size was non empty but the actual check should be that it's null which means not initialized. The map will never be non empty if it is set.
This restores the previous check that used to check for a null ref