Several misc Fate changes #4912
Conversation
- Add a toString() to FateKey - Move MetaFateStore to org.apache.accumulo.core.fate.zookeeper - Periodic clean up of dead reservations increased from every 30 seconds to every few minutes - New fate test case added to FateIT that ensures no write ops can be performed on a transaction after it has been deleted - Added new check to verifyReserved() that checks whether the transaction is deleted - Fixed UserFateStoreIT to work with new change and misc cleanup to the class
To improve the test time could use a strategy similar to FlakyFateManager and a test like ComprehensiveFlakyFateIT. So could create a FastFateCleanupManager that creates fate with a much lower cycle time and then have the test use that manager class. |
| .allMatch(entry -> FateStore.FateReservation.locksAreEqual(entry.getLockID(), lock2)); | ||
| return store2Reservations.keySet().equals(allIds) && allReservedWithLock2; | ||
| }, 60_000); | ||
| }, 60_000 * 4); |
There was a problem hiding this comment.
This change is needed because the manager cleans up dead reservations less frequently?
There was a problem hiding this comment.
yes
9599bd8 changed this to 30 seconds with use of FastFate
- created new class FastFate which performs the dead reservation cleanup more often
Yeah good idea. I created |
keith-turner
left a comment
keith-turner
left a comment
There was a problem hiding this comment.
@kevinrr888 how long does the test take to run now?
|
@keith-turner just 30-40 seconds |
3 participants
This PR addresses some follow on changes from #4524 (comment):
A couple questions: