Skip to content

adds early return for all sys tables in ClientTabletCacheImpl.request… #5487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ddanielr merged 1 commit into from
Apr 19, 2025
Merged

adds early return for all sys tables in ClientTabletCacheImpl.request… #5487

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/main/java/org/apache/accumulo/core/clientImpl/ClientTabletCacheImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -632,7 +632,7 @@ private void requestTabletHosting(ClientContext context,
}

// System tables should always be hosted
if (AccumuloTable.ROOT.tableId() == tableId || AccumuloTable.METADATA.tableId() == tableId) {
if (AccumuloTable.allTableIds().contains(tableId)) {
Copy link
Member

@ctubbsii ctubbsii Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the class AccumuloTable is really a misnomer. It's really TablesInTheAccumuloNamespace, and would probably be more intuitive if named AccumuloNamespace, with methods like .containsTable(tableId), or .tables().contains(TableId). There are several places in the code that have this pattern of checking that a tableId is contained in this set that would benefit from such a change. A similar comment was made on #5451

Copy link
Member Author

@kevinrr888 kevinrr888 Apr 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created #5498

return;
}

Expand Down