Skip to content

IVY-1606: incorrect dependency order on buildlist #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
skuhnert wants to merge 1 commit into
base: master
Choose a base branch
from
Open

IVY-1606: incorrect dependency order on buildlist #89

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion src/java/org/apache/ivy/core/sort/SortEngine.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,12 @@
import java.util.Map;

import org.apache.ivy.core.module.descriptor.ModuleDescriptor;
import org.apache.ivy.core.module.id.ModuleRevisionId;
import org.apache.ivy.core.resolve.IvyNode;
import org.apache.ivy.plugins.circular.CircularDependencyException;
import org.apache.ivy.plugins.circular.CircularDependencyStrategy;
import org.apache.ivy.plugins.circular.IgnoreCircularDependencyStrategy;
import org.apache.ivy.plugins.version.AbstractVersionMatcher;
import org.apache.ivy.plugins.version.VersionMatcher;
import org.apache.ivy.util.Checks;

Expand Down Expand Up @@ -120,7 +122,19 @@ protected CircularDependencyStrategy getCircularStrategy() {
}

protected VersionMatcher getVersionMatcher() {
return settings.getVersionMatcher();
VersionMatcher matcher = new AbstractVersionMatcher("all") {

@Override
public boolean isDynamic(ModuleRevisionId askedMrid) {
return false;
}

@Override
public boolean accept(ModuleRevisionId askedMrid, ModuleRevisionId foundMrid) {
return true;
}
};
return matcher;
}

}