feat: add PROXY protocol support #813
Open
+57
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperakos
changed the title
casperakos
changed the title
|
Sorry to just ping you maintainers but any update on this? We are using the PROXY protocol in multiple APISIX deployments and have to manually overwrite the settings on any update or change of them. We'd really appreciate the merge of this PR. Thanks for your work |
|
@juzhiyuan @guoqqqi Sorry to ping you but this is opened since mar 4, can you please have a look at the pr? thank you in advance ;) |
AlinsRan
reviewed
Nov 26, 2025
Address review feedback to nest proxyProtocol configuration under the apisix section for consistency with other APISIX-specific settings. Updated references in configmap.yaml, values.schema.json, and README.md to use .Values.apisix.proxyProtocol instead of .Values.proxyProtocol.
Author
|
Hi @AlinsRan, I've addressed your feedback and moved the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to add support for configuring the PROXY protocol in the APISIX helm chart. Currently, the PROXY protocol configuration exists in the template as commented code, but there's no way to enable or configure it via values.yaml.
Motivation
The PROXY protocol allows load balancers to pass client connection information to APISIX. This is especially useful in Kubernetes environments where APISIX is deployed behind a load balancer, and the original client IP needs to be preserved.
Implementation
Added proxy protocol configuration options to values.yaml with default values:
proxyProtocol:
enabled: false
listenHTTPPort: 9181
listenHTTPSPort: 9182
enableTCPPP: false
enableTCPPPToUpstream: false
Updated configmap.yaml to conditionally include proxy_protocol configuration when enabled
Added schema validation in values.schema.json for the new options
Updated README.md with documentation for the new configuration options
These changes allow users to easily enable and configure proxy protocol support through the helm chart values, rather than having to manually modify the configmap.
Fixes #812