GH-762: Implement VectorAppender for RunEndEncodedVector #884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViggoC
requested review from
jbonofre,
laurentgo,
lidavidm and
wgtmac
as code owners
This comment has been minimized.
This comment has been minimized.
lidavidm
reviewed
Oct 26, 2025
| public ValueVector visit(RunEndEncodedVector deltaVector, Void value) { | ||
| Preconditions.checkArgument( | ||
| typeVisitor.equals(deltaVector), | ||
| "The vector to append must have the same type as the targetVector being appended"); |
There was a problem hiding this comment.
Suggested change
| "The vector to append must have the same type as the targetVector being appended"); | |
| "The vector to append must have the same type as the deltaVector being appended"); |
Comment on lines
+729
to
+734
| // Shift the delta run-ends vector in-place before appending. | ||
| shiftRunEndsVector( | ||
| deltaRunEndsVector, | ||
| deltaRunEndsVector.getDataBuffer(), | ||
| targetLogicalValueCount, | ||
| deltaRunEndsVector.getValueCount()); |
There was a problem hiding this comment.
I don't think we ever defined it clearly, but I'm not sure that we want to modify deltaVector. It would be safer IMO to do this to a copy, or even just do the shift+append and never modify the delta run-ends vector.
Comment on lines
+744
to
+745
| private void shiftRunEndsVector( | ||
| ValueVector toRunEndVector, ArrowBuf fromRunEndBuffer, int offset, int physicalLength) { |
There was a problem hiding this comment.
It's also very confusing to frame this as a 'to vector' and 'from buffer' when really it is in an in-place change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changed
Implement VectorAppender for RunEndEncodedVector
Closes #762 .