-
Notifications
You must be signed in to change notification settings - Fork 14
ARTEMIS-5427 Integrate Jolokia's MBeanInfo cache #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2388275 to
32759ea
Compare
|
Jolokia releases are done. This should be ready to merge. |
pom.xml
Outdated
| <dependency> | ||
| <groupId>org.jolokia</groupId> | ||
| <artifactId>jolokia-server-detector</artifactId> | ||
| <version>${jolokia.version}</version> | ||
| </dependency> | ||
|
|
||
| <!-- Hawtio-related Jolokia deps to ensure we're not using multiple versions of Jolokia in the WAR --> | ||
| <dependency> | ||
| <groupId>org.jolokia</groupId> | ||
| <artifactId>jolokia-json</artifactId> | ||
| <version>${jolokia.version}</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.jolokia</groupId> | ||
| <artifactId>jolokia-server-core</artifactId> | ||
| <version>${jolokia.version}</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.jolokia</groupId> | ||
| <artifactId>jolokia-service-serializer</artifactId> | ||
| <version>${jolokia.version}</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.jolokia</groupId> | ||
| <artifactId>jolokia-service-jmx</artifactId> | ||
| <version>${jolokia.version}</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.jolokia</groupId> | ||
| <artifactId>jolokia-service-discovery</artifactId> | ||
| <version>${jolokia.version}</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.jolokia</groupId> | ||
| <artifactId>jolokia-service-history</artifactId> | ||
| <version>${jolokia.version}</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.jolokia</groupId> | ||
| <artifactId>jolokia-service-jsr160</artifactId> | ||
| <version>${jolokia.version}</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.jolokia</groupId> | ||
| <artifactId>jolokia-service-notif-pull</artifactId> | ||
| <version>${jolokia.version}</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.jolokia</groupId> | ||
| <artifactId>jolokia-service-notif-sse</artifactId> | ||
| <version>${jolokia.version}</version> | ||
| </dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With so many deps, and potential for others appearing later and then not being managed, maybe using the bom would be better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought the same thing at first so I tried using:
<dependency>
<groupId>org.jolokia</groupId>
<artifactId>jolokia-bom</artifactId>
<version>${jolokia.version}</version>
</dependency>However, all of the Jolokia-related jars in the WAR aside from the one for jolokia-server-detector came from 2.3.0. Maybe I'm missing something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ignore my previous comment. I think I've figured it out. Push incoming.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That snippet only manages the version of the artifact, if you were to have a unversioned/transitive dependency on it elsewhere in the build. You need to set the type to pom and scope to import to use the contained dependency entries as dependencyManagement, i.e to actually use it as a bom. Something like:
<dependency>
<groupId>org.jolokia</groupId>
<artifactId>jolokia-bom</artifactId>
<version>${jolokia.version}</version>
<type>pom</type>
<scope>import</scope>
</dependency>There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, view was stale, didnt see your comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ninja'd!
32759ea to
4a46c81
Compare
|
Testing latest console build, I can only see 1 call to jolokia that has "listCache=true" parameter - am I missing something? |
The value of
jolokia.versionwill need to be changed once jolokia/jolokia#925 is merged and released. Leaving this as a draft until then.This update makes a significant difference in high-load situations (e.g. thousands of addresses & queues) for the following:
I believe this will address the problems users have been reporting with web console load times and OOME on the broker.