Skip to content

Conversation

@GChuf
Copy link
Contributor

@GChuf GChuf commented Apr 12, 2025

Bumps both frontend and backend dependencies.
Perhaps most notably: bumps hawtio to 4.4.0 and @hawtio/react to the version used by hawtio console.

Updates README with some info and fixes some typos/mistakes. I also added "npm run start" info for users that have issues running "yarn start". The result is ultimately the same.

Needs some more testing but everything seems to work OK on my machine ... Let me know if anything needs changing.

@GChuf GChuf force-pushed the dependenciesUpdates branch from 5ca6246 to 5439432 Compare April 14, 2025 09:01
@GChuf GChuf marked this pull request as draft April 14, 2025 11:11
@GChuf GChuf force-pushed the dependenciesUpdates branch from 5439432 to 0018028 Compare April 14, 2025 11:21
@andytaylor
Copy link
Contributor

This is pulling in a few new dependencies, I have checked the licenses but if you could run 'yarn license' from the artemis-extension/artemis-extension dir this will update the NPMLicenses and if you couls rebase with this also added.

@andytaylor
Copy link
Contributor

The checks are failing because of an unapproved license '/home/runner/work/activemq-artemis-console/activemq-artemis-console/artemis-console-extension/artemis-extension/.yarnrc.yml'

Could you fixup up and rebase. fy mvn package -Prelease will run the check locally

@GChuf GChuf force-pushed the dependenciesUpdates branch from 0018028 to 93970eb Compare April 23, 2025 08:54
@GChuf
Copy link
Contributor Author

GChuf commented Apr 23, 2025

Rebased and pushed.
p.s. Is craco still used for tests? If not, that could be removed as well.

@GChuf GChuf force-pushed the dependenciesUpdates branch 2 times, most recently from 8b9c66e to 69d92fa Compare April 23, 2025 13:41
@andytaylor
Copy link
Contributor

I would leave Craco for now as I am doing some test stuff. could you update the update commit with a jira I have made https://issues.apache.org/jira/browse/ARTEMIS-5443.

@GChuf GChuf force-pushed the dependenciesUpdates branch from 69d92fa to 01da99d Compare April 23, 2025 13:46
@GChuf GChuf marked this pull request as ready for review April 23, 2025 13:47
@GChuf
Copy link
Contributor Author

GChuf commented Apr 23, 2025

Force pushed, i only changed the first commit's message, let me know if u want me to squash both commits into 1.
Licences were also properly fixed now.

@andytaylor
Copy link
Contributor

I think updating the readme is ok on its own. The checks passed so I will do some local testing and hopefully merge soon.

@andytaylor andytaylor merged commit 3718c6f into apache:main Apr 24, 2025
3 checks passed
@andytaylor
Copy link
Contributor

@GChuf I have merged this and will merge the others. There is a problem with PR workflows that need your yarn update. Couls you rebase all your PRs and then I will kick of workflows for them all?

@GChuf
Copy link
Contributor Author

GChuf commented Apr 24, 2025

@andytaylor I don't think any of the PRs need yarn/dependency updates for them to work - most if not all of the builds that fail (timeout), do so at "yarn build" stage, i assume because it's the most CPU intensive
Do you see any specific errors? I think all workflows should pass without any rebasing.

@andytaylor
Copy link
Contributor

I tried running several times yesterday and every run hung, I couldnt figure out why. the dep update passed fine tho as did the Fedora update both 1st time. They have been failing for a week or so. All I can think is that it is either the yarn version or changes in the fedora image that were causing it. I tried again this morning and one still failed. If its a big deal I will just test locally when I get a chance.

@GChuf
Copy link
Contributor Author

GChuf commented Apr 24, 2025

@andytaylor I rebased all the branches.
The way I see it, the processes hang and it's got nothing to do with dependencies. It's not a big deal but it is extra work - that said, I think builds are faster with updated dependencies, so maybe that helps as well - I'm also working on speeding up yarn build process in another branch.

Can you merge #65 first? That should get rid of 1 job, lower the load ...

@GChuf GChuf deleted the dependenciesUpdates branch November 7, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants