-
Notifications
You must be signed in to change notification settings - Fork 14
Update dependencies and README #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5ca6246 to
5439432
Compare
5439432 to
0018028
Compare
|
This is pulling in a few new dependencies, I have checked the licenses but if you could run 'yarn license' from the artemis-extension/artemis-extension dir this will update the NPMLicenses and if you couls rebase with this also added. |
|
The checks are failing because of an unapproved license '/home/runner/work/activemq-artemis-console/activemq-artemis-console/artemis-console-extension/artemis-extension/.yarnrc.yml' Could you fixup up and rebase. fy mvn package -Prelease will run the check locally |
0018028 to
93970eb
Compare
|
Rebased and pushed. |
8b9c66e to
69d92fa
Compare
|
I would leave Craco for now as I am doing some test stuff. could you update the update commit with a jira I have made https://issues.apache.org/jira/browse/ARTEMIS-5443. |
69d92fa to
01da99d
Compare
|
Force pushed, i only changed the first commit's message, let me know if u want me to squash both commits into 1. |
|
I think updating the readme is ok on its own. The checks passed so I will do some local testing and hopefully merge soon. |
|
@GChuf I have merged this and will merge the others. There is a problem with PR workflows that need your yarn update. Couls you rebase all your PRs and then I will kick of workflows for them all? |
|
@andytaylor I don't think any of the PRs need yarn/dependency updates for them to work - most if not all of the builds that fail (timeout), do so at "yarn build" stage, i assume because it's the most CPU intensive |
|
I tried running several times yesterday and every run hung, I couldnt figure out why. the dep update passed fine tho as did the Fedora update both 1st time. They have been failing for a week or so. All I can think is that it is either the yarn version or changes in the fedora image that were causing it. I tried again this morning and one still failed. If its a big deal I will just test locally when I get a chance. |
|
@andytaylor I rebased all the branches. Can you merge #65 first? That should get rid of 1 job, lower the load ... |
Bumps both frontend and backend dependencies.
Perhaps most notably: bumps hawtio to 4.4.0 and @hawtio/react to the version used by hawtio console.
Updates README with some info and fixes some typos/mistakes. I also added "npm run start" info for users that have issues running "yarn start". The result is ultimately the same.
Needs some more testing but everything seems to work OK on my machine ... Let me know if anything needs changing.