Skip to content

Conversation

@GChuf
Copy link
Contributor

@GChuf GChuf commented Apr 16, 2025

No description provided.

@andytaylor andytaylor self-requested a review April 22, 2025 12:28
@andytaylor
Copy link
Contributor

This looks great, however the messages table also needs the same change, it is a slightly different impl than ArtemisTable so in its own file

@GChuf GChuf marked this pull request as draft April 24, 2025 11:26
@andytaylor
Copy link
Contributor

@GChuf actually it doesnt make sense for the message table as it doesnt have a sort, could you just rebase and i will merge.

@GChuf GChuf marked this pull request as ready for review May 12, 2025 15:19
@GChuf
Copy link
Contributor Author

GChuf commented May 12, 2025

@andytaylor rebased - i might revisit this at some point for messages table.

Copy link
Contributor

@andytaylor andytaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@andytaylor andytaylor merged commit ae23c42 into apache:main May 12, 2025
2 checks passed
@GChuf GChuf deleted the ARTEMIS-5410 branch November 18, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants