Support markLedgerReplicated command.#4032
Open
horizonzy wants to merge 7 commits intoapache:masterfrom
Open
Conversation
Contributor
|
@horizonzy Would you please add more background of adding this command? |
Member
Author
Done |
zymap
reviewed
Jul 19, 2023
|
|
||
| MarkLedgerReplicatedCmd() { | ||
| super(CMD_MARKLEDGERREPLICATED); | ||
| opts.addOption("l", "ledgerid", true, "Ledger ID"); |
Member
There was a problem hiding this comment.
It's better to provide a list or range option to allow given a group of ledger id to mark. For example, we can use , to give a list of ledgers, "1,2,3,4,5,6". We also can use a range to specify the ledger, "1...10".
This can avoid calling this command multiple times when there has many ledgers that need to be marked.
hangc0276
reviewed
Jul 19, 2023
Contributor
hangc0276
left a comment
hangc0276
left a comment
There was a problem hiding this comment.
Please add the documents for the newly added command. Please refer to https://bookkeeper.apache.org/docs/reference/cli#bookkeeper-shell
|
|
||
| MarkLedgerReplicatedCmd() { | ||
| super(CMD_MARKLEDGERREPLICATED); | ||
| opts.addOption("l", "ledgerid", true, "Ledger ID"); |
hangc0276
requested review from
StevenLuMT,
eolivelli,
nicoloboschi and
wenbingshen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support markLedgerReplicated command.
Motivation:
Sometimes, users need to decommission a bookie, but there are under-replicated ledgers on the bookie that would be blocked during decommission. When users don't care about the under-replicated data, they hope to mark the ledger directly as replicated so that the decommission can proceed smoothly.