ReadLedgerCommand can't get lastEntry when specifying the ledger rang…

[liubingxing]

When we use the ReadLedgerCommand to read the ledger with entry range
bookkeeper shell readledger -l < ledgerId > -fe <firstEntryId> -le <lastEntryId>
This will return the entry in range [firstEntryId, lastEntryId].

If we specifying the bookie addr to read the ledger with entry range
bookkeeper shell readledger -b <bookieId> -l <ledgerId> -fe <firstEntryId> -le <lastEntryId>
It will return the entry in range [firstEntryId, lastEntryId) , the lastEntry is not included.

Because the LongStream.range will not include the lastEntry

We should replace LongStream.range with LongStream.rangeClosed

[hangc0276]

Nice catch!

[hangc0276]

rerun failure checks

[hangc0276]

rerun failure checks

[hangc0276]

@liubingxing Would you please help take a look at the failed tests?

[liubingxing]

@liubingxing Would you please help take a look at the failed tests?

@hangc0276 Sorry, I didn't notice these failed tests, I will fix them as soon as possible.

[liubingxing]

@hangc0276
I runed the command "mvn clean package -B -nsu -DskipBookKeeperServerTests -Dorg.slf4j.simpleLogger.defaultLogLevel=INFO" in my machine, and the results were always successful;
I'm not sure what the problem is, can you help me look at this problem.
Thanks a lot.

[hangc0276]

rerun failure checks

[hangc0276]

The test failed with timeout

bookkeeper/tools/ledger/src/test/java/org/apache/bookkeeper/tools/cli/commands/bookie/ReadLedgerCommandTest.java

Lines 131 to 140 in a79a4e2

	public void testWithBookieAddress() throws Exception {
	ReadLedgerCommand cmd = new ReadLedgerCommand();
	Assert.assertTrue(cmd.apply(bkFlags, new String[] { "-b", bookieSocketAddress.getId() }));
	Assert.assertEquals(1, getMockedConstruction(NioEventLoopGroup.class).constructed().size());
	Assert.assertEquals(1, getMockedConstruction(DefaultThreadFactory.class).constructed().size());
	Assert.assertEquals(1, getMockedConstruction(BookieClientImpl.class).constructed().size());
	verify(getMockedConstruction(NioEventLoopGroup.class).constructed().get(0), times(1)).shutdownGracefully();
	verify(orderedExecutor, times(1)).shutdown();
	verify(getMockedConstruction(BookieClientImpl.class).constructed().get(0), times(1)).close();
	}

The failed log is

2023-12-11T06:54:35.6468730Z [INFO] Running org.apache.bookkeeper.tools.cli.commands.bookie.LastMarkCommandTest
2023-12-11T06:54:37.4352864Z [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.787 s - in org.apache.bookkeeper.tools.cli.commands.bookie.LastMarkCommandTest
2023-12-11T06:54:37.6435604Z [INFO] Running org.apache.bookkeeper.tools.cli.commands.bookie.ReadLedgerCommandTest
2023-12-11T07:24:37.9277456Z [INFO] Running org.apache.bookkeeper.tools.cli.commands.bookie.SanityTestCommandTest
2023-12-11T07:24:39.8057608Z [INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.876 s - in org.apache.bookkeeper.tools.cli.commands.bookie.SanityTestCommandTest
2023-12-11T07:24:40.0306262Z [INFO] Running org.apache.bookkeeper.tools.cli.commands.bookie.ReadLogCommandTest

@liubingxing Please take a look, thanks.

[liubingxing]

The test failed with timeout

bookkeeper/tools/ledger/src/test/java/org/apache/bookkeeper/tools/cli/commands/bookie/ReadLedgerCommandTest.java

Lines 131 to 140 in a79a4e2

	public void testWithBookieAddress() throws Exception {
	ReadLedgerCommand cmd = new ReadLedgerCommand();
	Assert.assertTrue(cmd.apply(bkFlags, new String[] { "-b", bookieSocketAddress.getId() }));
	Assert.assertEquals(1, getMockedConstruction(NioEventLoopGroup.class).constructed().size());
	Assert.assertEquals(1, getMockedConstruction(DefaultThreadFactory.class).constructed().size());
	Assert.assertEquals(1, getMockedConstruction(BookieClientImpl.class).constructed().size());
	verify(getMockedConstruction(NioEventLoopGroup.class).constructed().get(0), times(1)).shutdownGracefully();
	verify(orderedExecutor, times(1)).shutdown();
	verify(getMockedConstruction(BookieClientImpl.class).constructed().get(0), times(1)).close();
	}

The failed log is

2023-12-11T06:54:35.6468730Z [INFO] Running org.apache.bookkeeper.tools.cli.commands.bookie.LastMarkCommandTest
2023-12-11T06:54:37.4352864Z [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.787 s - in org.apache.bookkeeper.tools.cli.commands.bookie.LastMarkCommandTest
2023-12-11T06:54:37.6435604Z [INFO] Running org.apache.bookkeeper.tools.cli.commands.bookie.ReadLedgerCommandTest
2023-12-11T07:24:37.9277456Z [INFO] Running org.apache.bookkeeper.tools.cli.commands.bookie.SanityTestCommandTest
2023-12-11T07:24:39.8057608Z [INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.876 s - in org.apache.bookkeeper.tools.cli.commands.bookie.SanityTestCommandTest
2023-12-11T07:24:40.0306262Z [INFO] Running org.apache.bookkeeper.tools.cli.commands.bookie.ReadLogCommandTest

@liubingxing Please take a look, thanks.

@hangc0276 Thanks for pointing out the error, I updated the code. Please review again.