#2974: Add hash-based journal selection for improved ledger distribution#4709
Open
jprieto-temporal wants to merge 3 commits intoapache:masterfrom
Open
#2974: Add hash-based journal selection for improved ledger distribution#4709jprieto-temporal wants to merge 3 commits intoapache:masterfrom
jprieto-temporal wants to merge 3 commits intoapache:masterfrom
Conversation
eolivelli
requested changes
Jan 31, 2026
| return journals.get(MathUtils.signSafeMod(ledgerId, journals.size())); | ||
| long index = ledgerId; | ||
| if (journalHashBasedSelection) { | ||
| index = ledgerId * FIBONACCI_HASH_CONSTANT; |
Contributor
There was a problem hiding this comment.
what about putting this block into a static method so that we can add unit tests ?
The function gets the index and the number of journals and computes the journal index
Author
There was a problem hiding this comment.
Thank you for your review. I added the tests and factored out the static method.
Contributor
|
there are other places where ledgerid is used for routing (e.g. ordered thread executor). |
Author
|
@dlg99 not opposed to factoring it out and using the same hashing that is used in this PR since it provides better distribution in the general case, but I think that could be done in a separate PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main Issue: #2974
Motivation
When multiple journals are configured, BookKeeper selects a journal using ledgerId % numJournals. This works well when
ledger IDs are random or sequential, but produces poor distribution when ledger IDs follow strided patterns (e.g., when
multiple clients allocate IDs from disjoint ranges). Uneven journal utilization can cause hotspots and reduce write
throughput.
Changes
patterns