fix: remove deprecated comment from RemovePolicy method#1662
Open
gszw90 wants to merge 1 commit intoapache:masterfrom
Open
fix: remove deprecated comment from RemovePolicy method#1662gszw90 wants to merge 1 commit intoapache:masterfrom
gszw90 wants to merge 1 commit intoapache:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR corrects an incorrect deprecation comment on the RemovePolicy method that was mistakenly suggesting users should use AddPoliciesWithAffected instead. The removal is appropriate since:
RemovePolicyremoves a single policy ruleAddPoliciesWithAffectedadds multiple policy rules- These methods serve opposite purposes (remove vs. add)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an incorrect deprecation comment in the RemovePolicy method.
The current comment states:
However, this is incorrect because:
The deprecation comment has been removed as it was providing incorrect guidance to users of the API.
Note: This issue exists in both v2 and v3 versions of the library.